Re: Remaining dependency on setlocale()

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Jeff Davis <pgsql(at)j-davis(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Remaining dependency on setlocale()
Date: 2026-01-12 07:37:39
Message-ID: 1eef20ab-7f0e-44b7-a443-a136bea11811@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06.01.26 23:20, Jeff Davis wrote:
> On Tue, 2026-01-06 at 20:54 +0100, Peter Eisentraut wrote:
>> On further reflection, it seems just as easy to have dmetaphone()
>> take
>> the input collation and use that to do a proper collation-aware
>> upper-casing.  This has the same effect (that is, it will still only
>> support certain single-byte encodings), but it avoids elaborately
>> hard-coding a bunch of things, and if we ever want to make this
>> multibyte-aware, then we'll have to go this way anyway, I think.  See
>> attached patch.
>
> Looks good to me.

committed

> After you commit that, we still need the changes in fuzzystrmatch.c,
> right?

right

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message tushar 2026-01-12 08:09:20 Re: Non-text mode for pg_dumpall
Previous Message tushar 2026-01-12 07:35:52 Re: Non-text mode for pg_dumpall