From: | Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> |
---|---|
To: | Satoshi Nagayasu <snaga(at)uptime(dot)jp> |
Cc: | PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Statistics collection for CLUSTER command |
Date: | 2013-10-15 11:52:42 |
Message-ID: | 525D2C8A.2030702@dalibo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 09/16/2013 08:26 AM, Satoshi Nagayasu wrote:
> (2013/08/08 20:52), Vik Fearing wrote:
>> As part of routine maintenance monitoring, it is interesting for us to
>> have statistics on the CLUSTER command (timestamp of last run, and
>> number of runs since stat reset) like we have for (auto)ANALYZE and
>> (auto)VACUUM. Patch against today's HEAD attached.
>>
>> I would add this to the next commitfest but I seem to be unable to log
>> in with my community account (I can log in to the wiki). Help
>> appreciated.
>
> I have reviewed the patch.
Thank you for your review.
> Succeeded to build with the latest HEAD, and passed the regression
> tests.
>
> Looks good enough, and I'd like to add a test case here, not only
> for the view definition, but also working correctly.
>
> Please take a look at attached one.
Looks good to me. Attached is a rebased patch with those tests added.
--
Vik
Attachment | Content-Type | Size |
---|---|---|
clusterstats.v2.patch | text/x-patch | 32.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2013-10-15 12:15:23 | Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE |
Previous Message | Vik Fearing | 2013-10-15 11:35:26 | Re: SSL renegotiation |