Re: Rationalizing code-sharing among src/bin/ directories

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Rationalizing code-sharing among src/bin/ directories
Date: 2016-03-24 16:39:54
Message-ID: 5246.1458837594@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> This name is a bit arbitrary, but most of what's there is string
>> processing of some flavor or other, with some list processing thrown
>> in for good measure. If anyone's got a different color to paint this
>> bikeshed, please speak up.

> I wondered about the list stuff while messing about in pg_dump awhile
> ago. It seems moderately okay, but not terribly generic; maybe we
> should get rid of all that stuff and make ilist.c available to frontend.
> Not sure how easy is that, given that AFAIR ilist uses elog. Anyway
> maybe we can discuss that in the future, to avoid blocking your patch.

It wouldn't be terribly hard to split the file into, say, string_utils
and simple_list files. On reflection that seems like a good idea as
long as we're going for cleanup rather than a one-to-one rename.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Matt Wilmas 2016-03-24 16:40:48 Re: btree_gin and btree_gist for enums
Previous Message Robert Haas 2016-03-24 16:28:57 Re: VS 2015 support in src/tools/msvc