Re: BUG #15548: Unaccent does not remove combining diacritical characters

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Hugh Ranalli <hugh(at)whtc(dot)ca>, thomas(dot)munro(at)enterprisedb(dot)com
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Verite <daniel(at)manitou-mail(dot)org>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
Date: 2019-01-02 17:41:40
Message-ID: 522acda7-c7fe-4b2e-f134-02c73a091be9@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 20/12/2018 23:39, Hugh Ranalli wrote:
> 01 - Updates generate_unaccent_rules.py to be Python 2 and 3 compatible.

My opinion is that we should just convert the whole thing to Python 3
and be done. This script is only run rarely, on a developer's machine,
so it's not unreasonable to expect Python 3 to be available.

The only other Python script I can find in the source is
src/test/locale/sort-test.py, which we should similarly convert.

> This patch also updates sql/unaccent.sql to UTF-8 format.

I have committed that in the meantime.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Hugh Ranalli 2019-01-02 17:58:03 Re: BUG #15548: Unaccent does not remove combining diacritical characters
Previous Message Alexey Bashtanov 2019-01-02 17:33:12 Is temporary functions feature official/supported? Found some issues with it.

Browse pgsql-hackers by date

  From Date Subject
Next Message Hugh Ranalli 2019-01-02 17:58:03 Re: BUG #15548: Unaccent does not remove combining diacritical characters
Previous Message Tom Lane 2019-01-02 16:35:46 Re: [PATCH] check for ctags utility in make_ctags