From: | David Steele <david(at)pgmasters(dot)net> |
---|---|
To: | Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, Haozhou Wang <hawang(at)pivotal(dot)io>, Anthony Bykov <a(dot)bykov(at)postgrespro(dot)ru> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Paul Guo <pguo(at)pivotal(dot)io>, Hubert Zhang <hzhang(at)pivotal(dot)io> |
Subject: | Re: [PATCH] Add missing type conversion functions for PL/Python |
Date: | 2018-04-10 13:35:39 |
Message-ID: | 5215a199-3b41-650e-3334-fe300356d067@pgmasters.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 3/26/18 12:07 PM, Nikita Glukhov wrote:
> On 26.03.2018 17:19, David Steele wrote:
>
>> On 2/20/18 10:14 AM, Haozhou Wang wrote:
>>> Thank you very much for your review!
>>>
>>> I attached a new patch with typo fixed.
>> I think it's a bit premature to mark this Ready for Committer after a
>> review consisting of a few typos. Anthony only said that he started
>> looking at it so I've marked it Needs Review.
>
> Hi.
>
> I also have looked at this patch and found some problems.
> Attached fixed 3th version of the patch:
> * initialization of arg->u.scalar was moved into PLy_output_setup_func()
> * added range checks for int16 and int32 types
> * added subroutine PLyInt_AsLong() for correct handling OverflowError
> that can
> be thrown from PyInt_AsLong()
> * casting from Python float to PostgreSQL numeric using
> PyFloat_AsDouble() was
> removed because it can return incorrect result for Python long and
> float8_numeric() uses float8 and numeric I/O functions
> * fixed whitespace
There's a new patch on this thread but since it was not submitted by the
author I've moved this entry to the next CF in Waiting for Author state.
Regards,
--
-David
david(at)pgmasters(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2018-04-10 13:37:55 | Re: Bugs in TOAST handling, OID assignment and redo recovery |
Previous Message | David Steele | 2018-04-10 13:32:02 | Re: jsonpath |