Re: No libldap_r in OpenLDAP 2.5 - use LDAP_API_FEATURE_X_OPENLDAP_REENTRANT from ldap_features.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dilyan Palauzov <Dilyan(dot)Palauzov(at)aegee(dot)org>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: No libldap_r in OpenLDAP 2.5 - use LDAP_API_FEATURE_X_OPENLDAP_REENTRANT from ldap_features.h
Date: 2021-08-25 06:29:38
Message-ID: 520273.1629872978@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Dilyan Palauzov <Dilyan(dot)Palauzov(at)aegee(dot)org> writes:
> The current postgres/configure.ac logic is: if libldap_r is availabe,
> then use it, otherwise use libldap.

Right.

> I propose, instead of looking for the presence of libldap_r, to check
> the feature macro, and if libldap is reentrant, not to use libldap_r .

Why? This seems more fragile (i.e., it adds an assumption that the
visible header file matches the available libraries), and if there is
a concrete benefit, you did not say what that is.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Rainer Tammer 2021-08-25 07:04:41 Re: Postgres 9.2.13 on AIX 7.1
Previous Message Masahiko Sawada 2021-08-25 06:01:15 Re: BUG #17156: pg_restore: [custom archiver] WARNING: ftell mismatch with expected position -- ftell used