| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Satoshi Nagayasu <snaga(at)uptime(dot)jp>, Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_filedump 9.3: checksums (and a few other fixes) |
| Date: | 2013-07-16 21:31:03 |
| Message-ID: | 51E5BB97.4030901@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/08/2013 04:59 PM, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> Well, Tom opined in
>> http://www.postgresql.org/message-id/23249.1370878717@sss.pgh.pa.us that
>> the current patch is okay. I have a mild opinion that it should instead
>> print only SHR_LOCK when both bits are set, and one of the others when
>> only one of them is set. But I don't have a strong opinion about this,
>> and since Tom disagrees with me, feel free to exercise your own (Jeff's)
>> judgement.
>
> FWIW, I think that's exactly what I did in the preliminary 9.3 patch
> that I committed to pg_filedump a few weeks ago. Could you take a look
> at what's there now and see if that's what you meant?
So, is this getting committed today, or do we bounce it?
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2013-07-16 21:34:55 | Re: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review] |
| Previous Message | Martijn van Oosterhout | 2013-07-16 21:07:27 | Re: Proposal - Support for National Characters functionality |