Re: --with-libedit-preferred is bad design

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: --with-libedit-preferred is bad design
Date: 2013-07-13 02:10:22
Message-ID: 51E0B70E.10003@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 07/12/2013 06:31 PM, Tom Lane wrote:
> Josh Berkus <josh(at)agliodbs(dot)com> writes:
>> I think the current --with-libedit-preferred should go away, and be
>> replaced by a --with-libedit option which throws an error if libedit
>> isn't found.
>
> I'm not sure that will work well on systems where libedit masquerades
> as readline...

Ah, was that the thinking behind that? In that case, maybe we could put
a warning in the config.log that libedit wasn't found? Right now,
there's nothing.

>
> TBH, given the number of bugs we've hit in libedit, encouraging its use
> isn't something we should put effort into anyway. Or is it just that
> Apple seems incapable of finding non-broken versions to ship?

That would hardly be only true of libedit, on Apple.

It's also broken on some Red Hat versions, last I checked.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit kapila 2013-07-13 03:38:19 Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])
Previous Message Tatsuo Ishii 2013-07-13 02:03:36 Re: pgbench patches