| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: XLogInsert scaling, revisited |
| Date: | 2013-07-08 09:23:06 |
| Message-ID: | 51DA84FA.4070703@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27.06.2013 20:36, Andres Freund wrote:
> On 2013-06-26 18:52:30 +0300, Heikki Linnakangas wrote:
>> There's this in the comment near the top of the file:
>
> Btw, I find the 'you' used in the comment somewhat irritating. Not badly
> so, but reading something like:
>
> * When you are about to write
> * out WAL, it is important to call WaitXLogInsertionsToFinish() *before*
> * acquiring WALWriteLock, to avoid deadlocks. Otherwise you might get stuck
> * waiting for an insertion to finish (or at least advance to next
> * uninitialized page), while you're holding WALWriteLock.
>
> just seems strange to me. If this directed at plugin authors, maybe, but
> it really isn't...
Agreed, that was bad wording. Fixed.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Markus Wanner | 2013-07-08 09:39:05 | Re: Review: extension template |
| Previous Message | Heikki Linnakangas | 2013-07-08 09:22:22 | Re: XLogInsert scaling, revisited |