From: | "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: units in postgresql.conf comments |
Date: | 2013-05-30 07:52:32 |
Message-ID: | 51A70540.1030205@commandprompt.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 05/30/2013 12:01 AM, Heikki Linnakangas wrote:
> We could make it mandatory to specify the unit in the value. Ie. throw
> an error on "wal_sender_timeout = 50":
>
> ERROR: unit required for option "wal_sender_timeout"
> HINT: Valid units for this parameter are "ms", "s", "min", "h", and "d".
>
> Then you wouldn't need a comment to explain what the unit of a naked
> value is. The only problem I see with that is backwards-compatibility.
> Old postgresql.conf files containing naked values would no longer work.
> But all you'd need to do is to add in the units, which would work on
> older versions too, and would be good for readability anyway.
I like this idea with one addition. We should have a default unit for
each. For wal_sender_timeout seconds makes sense, but for
checkpoint_timeout minutes makes sense (for example).
JD
>
> - Heikki
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2013-05-30 07:54:01 | Re: [PATCH] add --throttle to pgbench (submission 3) |
Previous Message | Craig Ringer | 2013-05-30 07:10:06 | Re: [PATCH] add --throttle to pgbench (submission 3) |