Re: pgsql: Inline pg_ascii_tolower() and pg_ascii_toupper().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Inline pg_ascii_tolower() and pg_ascii_toupper().
Date: 2025-11-28 20:40:19
Message-ID: 519380.1764362419@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)kurilemu(dot)de> writes:
> On 2025-Nov-26, Jeff Davis wrote:
>> Inline pg_ascii_tolower() and pg_ascii_toupper().

> I think this broke the CI on (some flavors of?) Windows. In
> https://cirrus-ci.com/task/6080935063453696
> I got

> [19:09:39.518] C:/msys64/ucrt64/bin/../lib/gcc/x86_64-w64-mingw32/15.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: src/backend/postgres_lib.a.p/commands_event_trigger.c.obj: in function `filter_list_to_array':
> [19:09:39.518] c:\cirrus\build/../src/backend/commands/event_trigger.c:377:(.text+0x2a5): undefined reference to `pg_ascii_toupper'

That's bizarre. I checked recent cfbot rebuilds of some of my patches
and there's no problem, also just looking at port.h it's impossible
to see how this could happen. Some weird compiled-code caching
misbehavior in CI, perhaps?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Chao Li 2025-11-29 01:54:25 Re: pgsql: Inline pg_ascii_tolower() and pg_ascii_toupper().
Previous Message Álvaro Herrera 2025-11-28 18:00:29 Re: pgsql: Inline pg_ascii_tolower() and pg_ascii_toupper().

Browse pgsql-hackers by date

  From Date Subject
Next Message Mihail Nikalayeu 2025-11-28 20:41:15 Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements
Previous Message Mihail Nikalayeu 2025-11-28 20:12:15 Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY