Re: PostgreSQL 9.3 beta breaks some extensions "make install"

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Marti Raudsepp <marti(at)juffo(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PostgreSQL 9.3 beta breaks some extensions "make install"
Date: 2013-05-14 02:58:21
Message-ID: 5191A84D.7000704@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 05/13/2013 10:27 PM, Peter Eisentraut wrote:
> On Tue, 2013-05-14 at 04:12 +0300, Marti Raudsepp wrote:
>> It's caused by this common pattern in extension makefiles:
>> DATA = $(wildcard sql/*--*.sql) sql/$(EXTENSION)--$(EXTVERSION).sql
>>
> What is the point of this? Why have the wildcard and then the
> non-wildcard term?
>
> I think using wildcard is bad style and you should fix it.
>

I've been caught by it. I'm not sure why the wildcard is a bad idea -
don't we want any present update sql files to be installed? . I don't
see any reason to have the redundant addition of the current version's
sql file, though.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-05-14 03:13:57 Re: commit fest schedule for 9.4
Previous Message David Fetter 2013-05-14 02:41:37 Re: fallocate / posix_fallocate for new WAL file creation (etc...)