Re: [PATCH] Remove unused #include's in src/backend/utils/adt/*

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Remove unused #include's in src/backend/utils/adt/*
Date: 2025-06-16 14:09:28
Message-ID: 519159.1750082968@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Aleksander Alekseev <aleksander(at)timescale(dot)com> writes:
> clangd indicates that certain #include's are redundant. Removing them
> will speed up the build process a bit.

The removals of <math.h> bother me a bit; I believe those used
to be necessary on some platforms. Maybe nowadays everybody is
close enough to POSIX that you can safely extrapolate from what
clangd says on your own machine, but it's not zero-risk.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2025-06-16 14:11:58 Re: No error checking when reading from file using zstd in pg_dump
Previous Message Tom Lane 2025-06-16 13:56:06 Re: No error checking when reading from file using zstd in pg_dump