Re: Asymmetric partition-wise JOIN

From: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
To: Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>
Cc: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Kohei KaiGai <kaigai(at)heterodb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Asymmetric partition-wise JOIN
Date: 2021-07-05 09:57:45
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 18/6/21 15:02, Alexander Pyhalov wrote:
> Andrey Lepikhov писал 2021-05-27 07:27:
>> Next version of the patch.
>> For searching any problems I forced this patch during 'make check'
>> tests. Some bugs were found and fixed.
> Hi.
> I've tested this patch and haven't found issues, but I have some comments.
Thank you for review!
> Variable names - child_join_rel and child_join_relids seem to be
> inconsistent with rest of the file

> When build_child_join_rel() can return NULL?
> Missing word:
> each bitmapset variable will large => each bitmapset variable will be large
> What hook do you refer to?
Removed> You've changed function to copy appinfo, so now comment is
Thanks, fixed> Do I understand correctly that now parent_relids also
contains relids of
> relations from 'global' inner relation, which we join to childs?

Andrey Lepikhov
Postgres Professional

Attachment Content-Type Size
v15-0001-Asymmetric-partitionwise-join.patch text/plain 32.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2021-07-05 10:04:29 Re: Numeric multiplication overflow errors
Previous Message Amit Kapila 2021-07-05 09:51:45 Re: Doc chapter for Hash Indexes