Re: Tab completion for SET TimeZone

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Tab completion for SET TimeZone
Date: 2022-03-16 13:40:49
Message-ID: 514658.1647438049@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari(at)ilmari(dot)org> writes:
> I just noticed I left out the = in the match check, here's an updated
> patch that fixes that.

Hmm .... is that actually going to be useful in that form?
Most time zone names contain slashes and will therefore require
single-quoting. I think you might need pushups comparable to
COMPLETE_WITH_ENUM_VALUE.

Also, personally, I'd rather not smash the names to lower case.
I think that's a significant decrement of readability.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2022-03-16 14:07:51 Re: Logical replication timeout problem
Previous Message Dagfinn Ilmari Mannsåker 2022-03-16 13:26:57 Re: Tab completion for SET TimeZone