Re: AIX support

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Aditya Kamath <Aditya(dot)Kamath1(at)ibm(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Srirama Kucherlapati <sriram(dot)rk(at)in(dot)ibm(dot)com>, "peter(at)eisentraut(dot)org" <peter(at)eisentraut(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "tristan(at)partin(dot)io" <tristan(at)partin(dot)io>, "postgres-ibm-aix(at)wwpdl(dot)vnet(dot)ibm(dot)com" <postgres-ibm-aix(at)wwpdl(dot)vnet(dot)ibm(dot)com>
Subject: Re: AIX support
Date: 2026-02-02 15:19:00
Message-ID: 513631.1770045540@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Aditya Kamath <Aditya(dot)Kamath1(at)ibm(dot)com> writes:
> Thank you very much for the support and guidance so far. Please find attached v2 of the meson changes. (See: 0001-Add-AIX-support-for-Postgresql-using-meson-build-too.patch)

Please, don't squash all of the changes under discussion into a single
patch. We aren't likely to commit it like that, and merging different
topics into one patch just makes it harder to review everything.
In this case, it'd have been much better if you kept my changes from
https://www.postgresql.org/message-id/1694571.1769736080@sss.pgh.pa.us
separate from the rest, so that it'd be easier to compare your work
to the previous version 0001-Support-for-AIX.pg19.v11.patch.

Also, please pretty please use systematic naming including a version
number for new patches. It's far from obvious that
0001-Add-AIX-support-for-Postgresql-using-meson-build-too.patch is
newer than 0001-Support-for-AIX.pg19.v11.patch. (If you're making
the patch files with git format-patch, use "-v N".)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2026-02-02 15:26:48 Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts
Previous Message Heikki Linnakangas 2026-02-02 14:38:09 Fix pg_stat_get_backend_wait_event() for aux processes