Re: pgsql: Refactor all TAP test suites doing connection checks

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Date: 2021-04-05 14:57:22
Message-ID: 513200.1617634642@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> Refactor all TAP test suites doing connection checks

Some of the buildfarm seems not to like this. gaur failed here:

==~_~===-=-===~_~== pgsql.build/src/test/authentication/tmp_check/log/regress_log_001_password ==~_~===-=-===~_~==
...
ok 8 - authentication success for method md5, role md5_role
### Reloading node "primary"
# Running: pg_ctl -D /home/bfarm/bf-data/HEAD/pgsql.build/src/test/authentication/tmp_check/t_001_password_primary_data/pgdata reload
server signaled
ack Broken pipe: write( 11, 'SELECT $$connected with user=scram_role$$' ) at /opt/perl5.8.9/lib/site_perl/5.8.9/IPC/Run/IO.pm line 558

and I think hoverfly's failure is the same thing.

I didn't look at the code, but I bet this is similar to the race
conditions we've seen before where a server process may exit before
the perl test script finishes stuffing a command down the pipe.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2021-04-05 15:47:14 pgsql: Align some terms in arch-dev.sgml to glossary
Previous Message Peter Eisentraut 2021-04-05 07:17:14 pgsql: Renumber cursor option flags