Re: Doc patch, normalize search_path in index

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: "Karl O(dot) Pinc" <kop(at)meme(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Doc patch, normalize search_path in index
Date: 2013-01-25 18:46:46
Message-ID: 5102D316.3040000@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/25/13 12:50 PM, Bruce Momjian wrote:
> On Fri, Sep 28, 2012 at 12:40:38PM -0500, Karl O. Pinc wrote:
>> Hi,
>>
>> The attached patch (against git head)
>> normalizes "search_path" as the thing indexed
>> and uses a secondary index term to distinguish
>> the configuration parameter from the run-time
>> setting.
>>
>> "search path" the concept remains distinguished
>> in the index from "search_path" the setting/config param.
>> It's hard to say whether it's useful to make this
>> distinction. From a practical perspective it's easy
>> for the eye to stop scanning when the indent
>> level changes and so fail to notice that both
>> "search path" and "search_path" are index
>> entries. At least the index is a
>> lot more tidy than before.
>
> I have applied a modified version of your patch that creates separate
> secondary index references for search_path.

This matter was already closed:
https://commitfest.postgresql.org/action/patch_view?id=949

It looks like your patch reverts part of that.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-01-25 18:54:06 Re: "pg_ctl promote" exit status
Previous Message Bruce Momjian 2013-01-25 18:45:23 Re: Doc patch, normalize search_path in index