| From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: COMMENTS are not being copied in CREATE TABLE LIKE |
| Date: | 2026-02-12 15:33:59 |
| Message-ID: | 50f693ad-faec-4b1b-8de5-88dc90b236b4@uni-muenster.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/02/2026 16:08, Fujii Masao wrote:
> On Thu, Feb 12, 2026 at 11:36 PM Matheus Alcantara
> <matheusssilv97(at)gmail(dot)com> wrote:
>> The patch fix the issue and it seems correct to me.
Thanks for the review!
> The documentation [1] states that INCLUDING COMMENTS copies comments for
> the copied columns, constraints, and indexes. It does not mention copying
> comments on the table itself. Therefore, not copying table comments with
> INCLUDING COMMENTS does not appear to be a bug. That is, the proposed patch
> seems more like an improvement than a bug fix.
Hmm, it seemed so obvious to me that I didn’t look more closely at the
documentation :) Although I struggle to see the rationale for not
copying a table’s comment in a CREATE TABLE LIKE ... INCLUDING COMMENTS
statement, I have to agree that the documentation is quite clear about
this limitation, and therefore it cannot really be considered a bug.
That said, it may well be worth considering for a future release.
What are your thoughts?
Thanks!
Best, Jim
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-02-12 15:53:46 | Re: pgsql: Add file_extend_method=posix_fallocate,write_zeros. |
| Previous Message | Fujii Masao | 2026-02-12 15:08:16 | Re: COMMENTS are not being copied in CREATE TABLE LIKE |