| From: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, vladimirlesk(at)yandex-team(dot)ru, Dmitriy Sarafannikov <dsarafan(at)yandex-team(dot)ru> |
| Subject: | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |
| Date: | 2018-10-22 15:51:27 |
| Message-ID: | 50b94dcb-c744-ff2c-d6a4-3c371f8a7f9a@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Andrey,
Thank you for your reply.
> I think it is better to load restore_command from recovery.conf.
Yes, it seems to be the most native way. That's why I needed this
rewritten (mostly copy-pasted) frontend-safe version of parser (guc-file.l).
> I didn't actually try patch yet, but the idea seems interesting. Will
> you add it to the commitfest?
I am willing to add it to the November commitfest, but I have some
concerns regarding frontend version of GUC parser. Probably, it is
possible to refactor guc-file.l to use it on both front- and backend.
However, it requires usage of IFDEF and mocking up ereport for frontend,
which is a bit ugly.
--
Alexey Kondratov
Postgres Professional: https://www.postgrespro.com
Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-10-22 17:12:28 | Re: removing unnecessary get_att*() lsyscache functions |
| Previous Message | Alvaro Herrera | 2018-10-22 15:45:28 | Re: relhassubclass and partitioned indexes |