Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Make pg_basebackup configure and start standby [Review]

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Make pg_basebackup configure and start standby [Review]
Date: 2013-01-05 16:17:03
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
2013-01-05 16:58 keltezéssel, Magnus Hagander írta:
> On Sat, Jan 5, 2013 at 3:41 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> On Thu, Jan 3, 2013 at 1:33 PM, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
>>> 2013-01-02 11:54 keltezéssel, Boszormenyi Zoltan írta:
>>> 2013-01-02 10:37 keltezéssel, Boszormenyi Zoltan írta:
>>> 2013-01-02 10:12 keltezéssel, Magnus Hagander írta:
>>> Attached is the quotes-v2 patch, the function is renamed and
>>> the comment is modified plus the pg_basebackup v21 patch
>>> that uses this function.
>>> Rebased after pgtar.h was added. The quotes.c comment was modified
>>> even more so it doesn't say this function is used for SQL string literals.
>> Quotes patch applied with a few small changes:
>> 1) Support for the msvc build (needs an entry added for new files that
>> go in src/port if they should be used on Windows)
>> 2) Makefile entries should be alphabetical (yes, that's really trivial
>> nitpicking :D)
> After some further modifications, I've applied the pg_basebackup patch as well.

Thank you very much!

> Thanks! And again, apologies for dragging the process out longer than
> should've been necessary.

I blamed it on me not having done reviews earlier in the commitfest,
which I finally did last week. Now, if only Tom could find some time
to review the lock_timeout patch... ;-)

Thanks again and best regards,
Zoltán Böszörményi

Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria

In response to

pgsql-hackers by date

Next:From: Pavel StehuleDate: 2013-01-05 16:55:03
Subject: Re: enhanced error fields
Previous:From: Stephen FrostDate: 2013-01-05 16:04:43
Subject: Re: Re: Proposal: Store "timestamptz" of database creation on "pg_database"

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group