2013-01-01 17:18 keltezéssel, Magnus Hagander írta:
> On Fri, Nov 30, 2012 at 10:13 AM, Boszormenyi Zoltan <zb(at)cybertec(dot)at
> <mailto:zb(at)cybertec(dot)at>> wrote:
> now that PQconninfo() was committed, I rebased the subsequent
> patches. Actual code change was only in the last patch, to
> conform to the committed PQconninfo() API.
> So, finally coming back to this one.
> What happened to Alvaro's suggestion of:
> > It seems simpler to have the escape_quotes utility function in port just
> > not use pg_malloc at all, have it return NULL or similar failure
> > indicator when malloc() fails, and then the caller decides what to do.
I seem to have skipped it while reading my mails,
I don't remember this suggestion at all. Sorry.
> That way we can get around the whole need for changing memory allocation across all the
> frontends, no? Like the attached.
Sure it's simpler but then the consistent look of the code is lost.
What about the other patch to unify pg_malloc and friends?
Basically all client code boils down to
in different disguise in their error reporting, so that patch can
also be simplified but it seems that the atexit() - either explicitly
or hidden behind InitPostgresFrontend() - cannot be avoided.
Cybertec Schönig & Schönig GmbH
A-2700 Wiener Neustadt, Austria
In response to
pgsql-hackers by date
|Next:||From: Noah Misch||Date: 2013-01-01 19:00:55|
|Subject: Re: default SSL compression (was: libpq compression)|
|Previous:||From: Magnus Hagander||Date: 2013-01-01 18:20:34|
|Subject: Re: [PATCH] Make pg_basebackup configure and start standby [Review]|