Fix fmgroids.h not regenerated after "clean" (not "clean dist") on Windows

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Fix fmgroids.h not regenerated after "clean" (not "clean dist") on Windows
Date: 2012-12-12 07:07:14
Message-ID: 50C82D22.1010903@2ndquadrant.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all

There's an issue with MSVC builds on Windows where clean.bat deletes
src\include\utils\fmgroids.h (as it should) but build.pl doesn't
re-create it reliably.

It's created fine on the first build because Gen_fmgrtab.pl is called if
src\backend\utils\fmgrtab.c is missing, which it is on first build.
Generating it also generates src\backend\utils\fmgroids.h, which is
copied to src\include. However, this copy isn't repeated after clean
deletes src\include\utils\fmgroids.h .

"clean dist" is fine, since it deletes fmgrtab.c too, causing the whole
thing to be re-generated.

The attached patch fixes the issue.

--
Craig Ringer

Attachment Content-Type Size
0001-Win32-replace-fmgroids.h-if-removed-by-clean.bat.patch text/plain 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2012-12-12 07:45:35 Re: skipping context for RAISE statements - maybe obsolete?
Previous Message Alvaro Herrera 2012-12-12 04:41:12 Re: Shuffling xlog header files