Re: Proposal for Allow postgresql.conf values to be changed via SQL

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Amit kapila <amit(dot)kapila(at)huawei(dot)com>
Cc: Greg Smith <greg(at)2ndQuadrant(dot)com>, 'Robert Haas' <robertmhaas(at)gmail(dot)com>, 'Tom Lane' <tgl(at)sss(dot)pgh(dot)pa(dot)us>, 'Magnus Hagander' <magnus(at)hagander(dot)net>, 'Christopher Browne' <cbbrowne(at)gmail(dot)com>, 'PostgreSQL-development' <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal for Allow postgresql.conf values to be changed via SQL
Date: 2012-11-13 18:13:08
Message-ID: 50A28DB4.3060306@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/12/12 7:59 PM, Amit kapila wrote:
> On Monday, November 12, 2012 12:07 PM Greg Smith wrote:
> On 11/9/12 11:59 PM, Amit kapila wrote:
>
>>> Please let me know if there are any objections or problems in above method of implementation,
>>> else I can go ahead to prepare the patch for the coming CF.
>
>> It may be the case that the locking scheme Robert described is the best
>> approach here. It seems kind of heavy to me though. I suspect that
>> some more thinking about it might come up with something better.

So, here's the problem I'm seeing with having a single .auto file: when
we write settings to a file, are we writing a *single* setting or *all
of a user's current settings*?

I was imagining writing single, specific settings, which inevitably
leads to one-setting-per-file, e.g.:

SET PERSISTENT work_mem = 256MB;

What Amit seems to be talking about is more EXPORT SETTINGS, where you
dump all current settings in the session to a file. This seems likely
to produce accidental changes when the user writes out settings they've
forgotten they changed.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-11-13 18:16:11 Re: Proposal for Allow postgresql.conf values to be changed via SQL
Previous Message Tom Lane 2012-11-13 17:38:33 Re: Proof of concept: standalone backend with full FE/BE protocol