Re: Fix errcontext() function

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Chen Huajun <chenhj(at)cn(dot)fujitsu(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fix errcontext() function
Date: 2012-11-12 15:21:12
Message-ID: 50A113E8.1070600@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10.11.2012 11:46, Chen Huajun wrote:
>> Unfortunately not all compilers support varargs macros. I bumped into
>> this in February, see
>> http://archives.postgresql.org/message-id/4F3B72E0.8040801@enterprisedb.com.
>> My last attempt to fix this was
>> at http://archives.postgresql.org/pgsql-hackers/2012-04/msg00812.php.
>> That patch is probably good to go, I just got busy with other things
>> and forgot about it back then. Can you take a look at that
>> patch and see if I missed anything, please?
>
> I think you are right,although the number of changed place is a a little
> bit large.
> Thanks for your answer!

Ok, I've committed this patch now, it will be fixed in 9.3. Thanks for
reminding me about this.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2012-11-12 15:40:57 Version 4.9 of PostgreSQL buildfarm client released
Previous Message Tom Lane 2012-11-12 15:19:09 Re: Inadequate thought about buffer locking during hot standby replay