From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
---|---|
To: | Amit kapila <amit(dot)kapila(at)huawei(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown |
Date: | 2012-11-08 08:33:42 |
Message-ID: | 509B6E66.9070408@vmware.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On 19.10.2012 14:42, Amit kapila wrote:
> On Thursday, October 18, 2012 8:49 PM Fujii Masao wrote:
>> Before implementing the timeout parameter, I think that it's better to change
>> both pg_basebackup background process and pg_receivexlog so that they
>> send back the reply message immediately when they receive the keepalive
>> message requesting the reply. Currently, they always ignore such keepalive
>> message, so status interval parameter (-s) in them always must be set to
>> the value less than replication timeout. We can avoid this troublesome
>> parameter setting by introducing the same logic of walreceiver into both
>> pg_basebackup background process and pg_receivexlog.
>
> Please find the patch attached to address the modification mentioned by you (send immediate reply for keepalive).
> Both basebackup and pg_receivexlog uses the same function ReceiveXLogStream, so single change for both will address the issue.
Thanks, committed this one after shuffling it around the changes I
committed yesterday. I also updated the docs to not claim that -s option
is required to avoid timeout disconnects anymore.
- Heikki
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2012-11-08 08:53:53 | Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown |
Previous Message | Craig Ringer | 2012-11-08 02:19:56 | Re: duplicate key value violates unique constraint "tableName_pk" |
From | Date | Subject | |
---|---|---|---|
Next Message | Filip Rembiałkowski | 2012-11-08 08:45:58 | Fwd: question on foreign key lock |
Previous Message | Dean Rasheed | 2012-11-08 08:33:39 | Re: Proof of concept: auto updatable views [Review of Patch] |