Re: [PATCH] Perform check for oversized WAL record before calculating record CRC

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Sergey Fukanchik <s(dot)fukanchik(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Perform check for oversized WAL record before calculating record CRC
Date: 2025-09-06 17:30:52
Message-ID: 509B5624-091E-45F9-B0D9-84DDE2C6CB94@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 6 Sep 2025, at 16:00, Sergey Fukanchik <s(dot)fukanchik(at)postgrespro(dot)ru> wrote:
>
> <0001-Perform-check-for-oversized-WAL-record-before-calcul.patch>

Hi Sergey!

It seems to me reasonable to move size check above CRC computation. However, it seems suspicious to me to run a test that allocates 1Gb in `make check`. Maybe, there are places that are not exercised too often. Perhaps recovery tests or something like that.

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabrice Chapuis 2025-09-07 08:02:06 Re: Issue with logical replication slot during switchover
Previous Message Srinath Reddy Sadipiralla 2025-09-06 16:33:45 [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL