From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_upgrade tests vs alter generic changes |
Date: | 2012-09-29 21:52:03 |
Message-ID: | 50676D83.8050000@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 09/29/2012 01:49 PM, Andrew Dunstan wrote:
>
> On 09/29/2012 11:49 AM, Tom Lane wrote:
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>> The recent alter generic tests have broken pg_upgrade testing on
>>> Windows
>>> and probably other non-collation-supporting platforms.
>> Is it still broken after Alvaro added the alternate expected file, and
>> if so why? I don't see a reason that this should be failing only there.
>> I also note that it seems to be passing fine on buildfarm members other
>> than pitta.
>
> Well, that's a very good point. chough is actually the same machine,
> doing an MSVC build. So why would this test pass there? I'll
> investigate a bit more. Here's what the regression diffs look like
> when run from pg_upgrade on pitta:
[hours of digging later]
It turns out that the reason is that we support collations on MSVC but
not on Mingw.
*sigh*
I'll have to put it on my ever lengthening TODO list.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2012-09-30 00:07:48 | pgsql: Disable _FORTIFY_SOURCE with ICC |
Previous Message | Andrew Dunstan | 2012-09-29 21:29:12 | Re: is JSON really "a type" (Re: data to json enhancements) |