Re: WIP: Enhanced ALTER OPERATOR

From: Uriy Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>
To: hlinnaka(at)iki(dot)fi
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: WIP: Enhanced ALTER OPERATOR
Date: 2015-07-10 13:35:19
Message-ID: 5051010.oZuSeXULOX@dinodell
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello.

On Friday 10 July 2015 15:46:35 you wrote:
> * I think it'd be better to use NONE instead of NULL above, to remove
> the estimator. It seems inconsistent when we've used NONE to mean
> "missing" earlier in the same statement.

Ok, you right.

> * The way you check for the NULL in OperatorUpd is wrong. It cannot
> distinguish between a quoted "null", meaning a function called "null",
> and a NULL, meaning no function.
With "none" has a similar problem. I need to correct the grammar.

>
> Attached is a new version of your patch, rebased over current master,
> and the docs formatting fixes.

Thanks. I hope to send the new patch on Monday.

--
Uriy Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2015-07-10 13:43:58 Re: Freeze avoidance of very large table.
Previous Message Vladimir Borodin 2015-07-10 13:29:09 Re: creating extension including dependencies