Enum binary access

From: Petr Chmelar <chmelarp(at)fit(dot)vutbr(dot)cz>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Enum binary access
Date: 2012-09-10 13:42:01
Message-ID: 504DEE29.6070301@fit.vutbr.cz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi there,

we tried to create the libpqtypes enum binary send but it doesn't work:

// register types
PGregisterType user_def[] = { {"seqtype", enum_put, enum_get} };
PQregisterTypes(connector->getConn(), PQT_USERDEFINED, user_def, 1, 0);

// enum_put throws format error
int enum_put (PGtypeArgs *args ) {

char *val = va_arg(args->ap, char *);
char *out = NULL;
int vallen = 0, len = 0, oid = 0;
float sortorder = 0.0;

if (!args || !val) return 0;

/* expand buffer enough */
vallen = strlen(val);
len = sizeof(int) + sizeof(float) + (vallen * sizeof(char));
if (args->put.expandBuffer(args, len) == -1) return -1;

/* put header (oid, sortorder) and value */
out = args->put.out;
memcpy(out, &oid, sizeof(int));
out += sizeof(int);
memcpy(out, &sortorder, sizeof(float));
out += sizeof(float);
memcpy(out, val, vallen);

return len;
}

// enum_get (FYI, get works OK)
int enum_get (PGtypeArgs *args) {
char *val = PQgetvalue(args->get.result, args->get.tup_num,
args->get.field_num);
int len = PQgetlength(args->get.result, args->get.tup_num,
args->get.field_num);
char **result = va_arg(args->ap, char **);
*result = (char *) PQresultAlloc((PGresult *) args->get.result, len
* sizeof(char));
memcpy(*result, val, len * sizeof(char));
return 0;
}

Postgres doesn't accept enum sent like this and throws format error.
This should be used as a prototype for derived types. There is no real
"enum" named type. Libpqypes doesn't seem to provide simplified binary
manipulation for enum types.

What should we do, please? Can you fix it? I think there is more people
that need access enum types in binary mode.

Cheers,

Petr and Vojtech

P.S. We have created the 9.1's cube extension send/receive functionality
as in https://gitorious.org/vtapi/vtapi/trees/master/postgres/cube

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2012-09-10 14:33:03 Re: Enum binary access
Previous Message Alvaro Herrera 2012-09-10 13:26:43 Re: Supporting plpython 2+3 builds better