From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | pg_upgrade bugs |
Date: | 2012-09-03 01:11:42 |
Message-ID: | 504403CE.2040209@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I have been wrestling for a couple of days trying to get pg_upgrade
testing working on Windows, with a view to having it tested on the
buildfarm. The test script has its own issues, which I'll deal with
separately, but there are two issues in pg_upgrade's exec.c that make me
suspect that if pg_upgrade has ever worked at all on Windows it is a
matter of sheer luck. The attached patch fixes these. The first issue is
a plain miscall to stlcpy(), where the length argument is wrong. The
second is where exec_prog tries to open a log file after the system call
returns. This will fail if the command was a 'pg_ctl start', as the
running postmaster will have the log file open, so I have simply
#ifdef'd it out for the Windows case, as the code does nothing except
add a couple of line feeds to the log, missing which won't affect
anything much.
Barring objection I will commit this before long.
cheers
andrew
Attachment | Content-Type | Size |
---|---|---|
pg_upgrade_exec.patch | text/x-patch | 803 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-09-03 01:39:41 | Re: pg_upgrade bugs |
Previous Message | Tom Lane | 2012-09-03 00:23:11 | Proof of concept: standalone backend with full FE/BE protocol |