Re: pg_archivecleanup bug

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Simon Riggs <simon(at)2ndQuadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndQuadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_archivecleanup bug
Date: 2014-03-19 03:25:08
Message-ID: 5024.1395199508@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Would people accept?

> for (errno = 0; (dirent = readdir(dir)) != NULL; errno = 0)

It's a bit weird looking, but I agree that there's value in only needing
the errno-zeroing in precisely one place.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Prabakaran, Vaishnavi 2014-03-19 03:29:16 Re: Providing catalog view to pg_hba.conf file - Patch submission
Previous Message Wang, Jing 2014-03-19 00:55:49 Re: issue log message to suggest VACUUM FULL if a table is nearly empty