Re: WIP pgindent replacement

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP pgindent replacement
Date: 2012-08-03 12:26:50
Message-ID: 501BC38A.1050703@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 08/02/2012 11:09 PM, Bruce Momjian wrote:

> Thirteen months after Andrew posted this WIP, I have restructured and
> tested this code, and it is now ready to replace the pgindent shell
> script as pgindent.pl, attached.
>
> I have tested this version by re-running the 9.1 and 9.2 pgindent runs
> and comparing the output, and it is just like Andrew said --- it is the
> same, except for the two improvements he mentioned.
>
> A Perl version of pgindent has several advantages:
>
> * more portable; less dependent on utility command variances
> * able to run on Windows, assuming someone makes entab and
> pg_bsd_indent Windows binaries
> * able to fix more limitations of pgindent
>
> I will add documentation about the arguments.
>
> Many thanks to Andrew for his fine work on this. Any objections?

Thanks for not forgetting this.

I think we generally don't put file type extensions on commands, so this
should probably just be renamed pgindent. If someone wants to go back to
the old shell script they can still get it from git.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2012-08-03 12:37:54 Re: Re: SPGiST versus hot standby - question about conflict resolution rules
Previous Message Amit Kapila 2012-08-03 12:10:48 FW: [WIP] Performance Improvement by reducing WAL for Update Operation