Re: misleading ALTER TABLE SET STORAGE

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Euler Taveira <euler(at)timbira(dot)com(dot)br>
Cc: vodevsh(at)gmail(dot)com, pgsql-docs(at)postgresql(dot)org
Subject: Re: misleading ALTER TABLE SET STORAGE
Date: 2016-11-10 15:04:06
Message-ID: 5019.1478790246@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

Euler Taveira <euler(at)timbira(dot)com(dot)br> writes:
> On 08-11-2016 11:27, vodevsh(at)gmail(dot)com wrote:
>> Was reading
>> https://www.postgresql.org/docs/current/static/storage-toast.html and the
>> bit with &quot;...table column can be altered with ALTER TABLE SET STORAGE...&quot;
>> appeared misleading to me.

> AFAICS ALTER TABLE SET STORAGE means ALTER TABLE ... ALTER COLUMN SET
> STORAGE. There is no ALTER TABLE SET STORAGE per table. It seems you are
> confusing with ALTER TABLE SET (storage_parameter = value, ...).

> Perhaps, we should use the complete command (ALTER TABLE tablename ALTER
> COLUMN colname SET STORAGE storagetype) or link ALTER TABLE to avoid
> confusion.

Our usual practice is to insert ellipses where there are omissions,
so this probably ought to read "ALTER TABLE ... SET STORAGE". We could
go with "ALTER TABLE ... ALTER COLUMN ... SET STORAGE", but that's
more verbose and not any more correct.

A link might not be a bad thing either, but it's sort of an independent
question.

regards, tom lane

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message vicky_vergara 2016-11-11 13:54:22 FuncCallContext's call_cntr & max_calls are uint64
Previous Message Euler Taveira 2016-11-10 14:46:34 Re: misleading ALTER TABLE SET STORAGE