Re: Remove redundant assignment in CreateWorkExprContext

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andreas Karlsson <andreas(at)proxel(dot)se>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Remove redundant assignment in CreateWorkExprContext
Date: 2026-01-14 20:03:01
Message-ID: 500d1ee81726b55c5482ac33f1334b6b59af2138.camel@j-davis.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2026-01-14 at 02:33 -0500, Tom Lane wrote:
> Looking at the git history, CreateWorkExprContext was introduced in
> 50a38f651, and at that time it did some nontrivial calculations
> to adjust that initial value of maxBlockSize.  Later, cc721c459
> simplified matters but forgot to remove the now-useless
> initialization.  So +1, unless Jeff has some reason to keep it
> like this?

Right. Committed, thank you.

Regards,
Jeff Davis

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2026-01-14 20:23:24 Re: libpq: Bump protocol version to version 3.2 at least until the first/second beta
Previous Message Jeff Davis 2026-01-14 19:53:42 Re: Use CASEFOLD() internally rather than LOWER()