From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule. |
Date: | 2012-07-20 20:21:35 |
Message-ID: | 5009BDCF.8030603@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 07/20/2012 04:17 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Remove prepared transactions from main isolation test schedule.
>> There is no point in running this test when prepared transactions are disabled,
>> which is the default. New make targets that include the test are provided. This
>> will save some useless waste of cycles on buildfarm machines.
> Having done that, shouldn't we remove prepared-transactions_1.out (the
> "expected" file for the prepared-transactions-disabled case)?
>
> Having a megabyte-sized test file for that case has always seemed pretty
> wasteful to me. Now that the test won't be run unless intentionally
> selected, it seems like people who are using it would expect it to
> actually test prepared transactions --- so having it "pass" when they're
> disabled seems wrong.
>
>
Good point. Will do.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2012-07-20 20:23:19 | pgsql: Temporary patch to try to debug why event trigger patch broke Wi |
Previous Message | Tom Lane | 2012-07-20 20:17:08 | Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule. |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2012-07-20 20:28:11 | Re: Restrict ALTER FUNCTION CALLED ON NULL INPUT (was Re: Not quite a security hole: CREATE LANGUAGE for non-superusers) |
Previous Message | Tom Lane | 2012-07-20 20:17:08 | Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule. |