| From: | "Tels" <nospam-abuse(at)bloodgate(dot)com> |
|---|---|
| To: | "Simon Riggs" <simon(at)2ndquadrant(dot)com> |
| Cc: | "David Rowley" <david(dot)rowley(at)2ndquadrant(dot)com>, "Kyotaro HORIGUCHI" <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "Tomas Vondra" <tomas(dot)vondra(at)2ndquadrant(dot)com>, "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com>, "David Fetter" <david(at)fetter(dot)org>, "Dean Rasheed" <dean(dot)a(dot)rasheed(at)gmail(dot)com>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: multivariate statistics (v25) |
| Date: | 2017-04-05 19:19:04 |
| Message-ID: | 5005eb93eea6ceef8bb6900baa7b9755.squirrel@sm.webmail.pair.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Moin,
On Wed, April 5, 2017 2:52 pm, Simon Riggs wrote:
> On 5 April 2017 at 10:47, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
> wrote:
>
>>> I have some other comments.
>
> Me too.
>
>
> CREATE STATISTICS should take ShareUpdateExclusiveLock like ANALYZE.
>
> This change is in line with other changes in this and earlier
> releases. Comments and docs included.
>
> Patch ready to be applied directly barring objections.
I know I'm a bit late, but isn't the syntax backwards?
"CREATE STATISTICS s1 WITH (dependencies) ON (col_a, col_b) FROM table;"
These do it the other way round:
CREATE INDEX idx ON table (col_a);
AND:
CREATE TABLE t (
id INT REFERENCES table_2 (col_b);
);
Won't this be confusing and make things hard to remember?
Sorry for not asking earlier, I somehow missed this.
Regard,
Tels
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-04-05 19:30:48 | Re: Add pgstathashindex() to get hash index table statistics. |
| Previous Message | Andres Freund | 2017-04-05 19:17:57 | Re: New SQL counter statistics view (pg_stat_sql) |