Re: BM_IO_ERROR flag is lost in TerminateBufferIO due to order of operations in UnlockBufHdrExt

From: Andres Freund <andres(at)anarazel(dot)de>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: BM_IO_ERROR flag is lost in TerminateBufferIO due to order of operations in UnlockBufHdrExt
Date: 2026-06-03 03:21:49
Message-ID: 4vq2uwymmaikzddxzgpmrxlesuo2ewnhnxxhgbwvfwejvqy4yb@gw6xtcvomtan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2026-06-02 12:15:40 -0400, Melanie Plageman wrote:
> On Mon, Apr 6, 2026 at 4:21 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > On Mon, Mar 30, 2026 at 11:25:55AM +0300, Yura Sokolov wrote:
> > > Have you any recommendations for patch?
> > >
> > > Should I create CF item for patch?
> >
> > The business with unset_flag_bits is new as of HEAD, so this could
> > qualify as an open item, to be tracked here:
> > https://wiki.postgresql.org/wiki/PostgreSQL_19_Open_Items
>
> There hasn't been recent activity on this thread and it is one of the
> oldest open items. Even if we don't have time to review the test right
> now, it is probably worth pushing the fix. Though we have just missed
> beta1...

Ugh. I had lost track of this. I'll get back to it as soon as I have squared
the CI stuff away.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-06-03 04:08:23 Re: Copy-paste error in hash_record_extended() — args[1].isnull not set
Previous Message Tingchuan Sun 2026-06-03 03:16:49 Re:Reject HEADER with binary and json COPY formats by option presence