| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: split tablecmds.c |
| Date: | 2025-12-01 19:50:44 |
| Message-ID: | 4gnkt2ztma27iqhl75xc4qkvxzozgufzcmhvvqgpyvq2c4745a@apnvrbr4muyb |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2025-12-01 11:25:13 -0600, Nathan Bossart wrote:
> This file has over 22,000 lines and is too large to be included in GitHub's
> code search results [0]. It appears to have been given its current form in
> 2002 by commit 71dc300. Previously, it was named command.c, which dates
> back to the 80s. Is it time to split it into a few different files,
> similar to what was done to copy.c in 2020 by commit c532d15?
>
> After briefly skimming through it, some areas that seem like they could
> potentially be moved out are partitions, constraints, permission checks,
> inheritance, foreign keys, column expressions, table rewriting, attribute
> merging, TRUNCATE, and CREATE TABLE. This is far from a concrete proposal,
> but I first wanted to gauge interest in $SUBJECT.
Seems reasonable, however I think that splitting all or most of the pieces you
listed into their own files would end up being pointlessly granular....
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2025-12-01 20:00:01 | Re: Improving tracking/processing of buildfarm test failures |
| Previous Message | Robert Haas | 2025-12-01 19:26:31 | Re: Improving the names generated for indexes on expressions |