| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Denis Hirn <denis(dot)hirn(at)uni-tuebingen(dot)de> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pantelis Theodosiou <ypercube(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Allow multiple recursive self-references |
| Date: | 2021-08-17 09:07:19 |
| Message-ID: | 4fd5d5f3-e662-868b-229d-40030a487fa4@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.07.21 13:15, Denis Hirn wrote:
>> In the next version of the patch, would you be so kind as to include
>> updated documentation of the feature and at least one regression test
>> of same?
>
> As requested, this new version of the patch contains regression tests and documentation.
The tests fail when you build with assertions enabled (configure
--enable-cassert).
Some quick style comments:
DocBook content should use 1-space indentation (not 2 spaces).
Typo?: /* we'll see this later */ -> "set"
Opening brace after "if" should be on new line. (See existing code.)
Also, there should be a space after "if".
These casts appear to be unnecessary:
if((Node *) stmt->larg != NULL && (Node *) stmt->rarg != NULL)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-08-17 09:14:20 | Re: pgstat_send_connstats() introduces unnecessary timestamp and UDP overhead |
| Previous Message | Amit Kapila | 2021-08-17 08:56:37 | Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o |