Re: Fix around conn_duration in pgbench

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
Cc: Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Subject: Re: Fix around conn_duration in pgbench
Date: 2021-08-11 04:56:27
Message-ID: 4fa49404-035c-901f-41d0-7a1a18c2e30e@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021/08/05 18:02, Yugo NAGATA wrote:
> this is a no-op because finishCon() is already called at CSTATE_ABORTED or
> CSTATE_FINISHED. Therefore, in the end, the disconnection delay is not
> measured even in v13.

Yes, but I was thinking that's a bug that we should fix.
IOW, I was thinking that, in v13, both connection and disconnection delays
should be measured whether -C is specified or not, *per spec*.
But, in v13, the disconnection delays are not measured in the cases
where -C is specified and not specified. So I was thinking that this is
a bug and we should fix those both cases.

But you're thinking that, in v13, the disconnection delays don't need to
be measured because they are not measured for now?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mahendra Singh Thalor 2021-08-11 05:00:25 Re: Support reset of Shared objects statistics in "pg_stat_reset" function
Previous Message David Rowley 2021-08-11 04:51:02 Allow parallel DISTINCT