| From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com>, Ahsan Hadi <ahsan(dot)hadi(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Soumyadeep Chakraborty <soumyadeep2007(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add session statistics to pg_stat_database |
| Date: | 2021-01-18 16:11:08 |
| Message-ID: | 4f0aacc5fe1b4bfafa32b36ecd97469fae526a75.camel@cybertec.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 2021-01-17 at 14:07 +0100, Magnus Hagander wrote:
> I have applied this version, with some minor changes:
>
> * I renamed the n_<x>_time members in the struct to just
> total_<x>_time. The n_ indicates "number of" and is thus wrong for
> time parameters.
Right.
> * Some very minor wording changes.
>
> * catversion bump (for once I didn't forget it!)
Thank you!
You included the catversion bump, but shouldn't PGSTAT_FILE_FORMAT_ID
in "include/pgstat.h" be updated as well?
Yours,
Laurenz Albe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-01-18 16:11:10 | Re: ResourceOwner refactoring |
| Previous Message | Robert Haas | 2021-01-18 16:08:53 | Re: support for MERGE |