Re: Tuplesort merge pre-reading

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Claudio Freire <klaussfreire(at)gmail(dot)com>
Cc: Peter Geoghegan <pg(at)heroku(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tuplesort merge pre-reading
Date: 2016-09-12 19:07:40
Message-ID: 4ecb109d-1b64-69f6-1dcd-d041b0fbba88@iki.fi
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 09/12/2016 06:47 PM, Claudio Freire wrote:
> On Mon, Sep 12, 2016 at 12:02 PM, Claudio Freire <klaussfreire(at)gmail(dot)com> wrote:
>> On Sun, Sep 11, 2016 at 12:47 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>>> Here's a new version of these patches, rebased over current master. I
>>> squashed the two patches into one, there's not much point to keep them
>>> separate.
>>
>> I don't know what was up with the other ones, but this one works fine.
>>
>> Benchmarking now.
>
> I spoke too soon, git AM had failed and I didn't notice.
>
> regression.diffs attached
>
> Built with
>
> ./configure --enable-debug --enable-cassert && make clean && make -j7
> && make check

Ah, of course! I had been building without assertions, as I was doing
performance testing. With --enable-cassert, it failed for me as well
(and there was even a compiler warning pointing out one of the issues).
Sorry about that.

Here's a fixed version. I'll go through Peter's comments and address
those, but I don't think there was anything there that should affect
performance much, so I think you can proceed with your benchmarking with
this version. (You'll also need to turn off assertions for that!)

- Heikki

Attachment Content-Type Size
0001-Change-the-way-pre-reading-in-external-sort-s-merge-.patch text/x-diff 58.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2016-09-12 19:09:22 Re: Tuplesort merge pre-reading
Previous Message Peter Eisentraut 2016-09-12 18:50:52 Re: PATCH: Exclude additional directories in pg_basebackup