| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Make copyObject work in C++ |
| Date: | 2026-01-20 16:28:00 |
| Message-ID: | 4e82f77b-acad-4356-94f6-8255135fb36b@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17.01.26 16:25, Jelte Fennema-Nio wrote:
>> AFAICT, the minimum changes to get a minimum test module to work are
>>
>> - fix for "restrict", recently committed
>> - disable warning about zero-length arrays, seems trivial
>> - named designated initializers
>
> Correct, I've now restructured the commits to have the module
> introduction as the first one. Then all the other commits, both fix a
> macro to work in C++ and add some usage of those macros as coverage to
> the previously added module.
I have split your first patch further. For a start, I left out the
PG_MODULE_MAGIC*-related changes and disabled the module under MSVC.
This has been committed. I plan to let the buildfarm run with it for a
day or two and then add in the basic MSVC support.
I implemented a different solution for checking whether C++ is available
under configure. The runtime check from the makefile looked a bit
fragile. This way, we now have a "have_cxx" variable available in both
meson and makefiles.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-01-20 16:38:29 | Re: Make copyObject work in C++ |
| Previous Message | Tristan Partin | 2026-01-20 16:22:26 | Re: meson: Allow disabling static libraries |