Re: Unify drop-by-OID functions

On 2020-05-01 17:44, Robert Haas wrote:
> On Fri, May 1, 2020 at 10:51 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> +1
>
> +1 from me, too, but I have a few suggestions:
>
> +DropGenericById(const ObjectAddress *object)
>
> How about "Generic" -> "Object" or "Generic" -> "ObjectAddress"?

Changed to "Object", that also matches existing functions that operate
on an ObjectAddress.

> + elog(ERROR, "cache lookup failed for %s entry %u",
> + elog(ERROR, "could not find tuple for class %u entry %u",
>
> How about "entry" -> "with OID"?

I changed these to just

"cache lookup failed for %s %u"
"could not find tuple for %s %u"

which matches the existing wording for the not-refactored cases. I
don't recall why I went and reworded them.

New patch attached. I'll park it until PG14 opens.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services