| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: PRI?64 vs Visual Studio (2022) |
| Date: | 2025-11-19 09:20:45 |
| Message-ID: | 4d8b1a67-aab2-4429-b44b-f03988095939@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19.11.25 03:13, Thomas Munro wrote:
> Interesting report though. Commit 962da900 assumed that our in-tree
> printf implementation still needed to understand that %I64 stuff in
> case it came to us from system headers, but it looks like it
> disappeared with MSVCRT:
>
> 1. I checked with CI (VS 2019). puts(PRId64) prints out "lld".
> 2. MinGW's inttypes.h[1] only uses "I64" et al if you build against MSVCRT.
>
> So I think we should delete that stuff. Attached.
Looks good to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2025-11-19 09:21:30 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |
| Previous Message | Chao Li | 2025-11-19 09:19:57 | Re: gen_guc_tables.pl: Validate required GUC fields before code generation |