| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: static assert cleanup |
| Date: | 2022-12-15 09:32:27 |
| Message-ID: | 4d61a288-cc0a-cd79-2cd8-2019415be939@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09.12.22 11:01, John Naylor wrote:
>
> On Fri, Dec 9, 2022 at 2:47 PM Peter Eisentraut
> <peter(dot)eisentraut(at)enterprisedb(dot)com
> <mailto:peter(dot)eisentraut(at)enterprisedb(dot)com>> wrote:
> >
> > 0003-Move-some-static-assertions-to-better-places.patch
> >
> > This moves some that I thought were suboptimally placed but it could be
> > debated or refined.
>
> + * We really want ItemPointerData to be exactly 6 bytes. This is rather a
> + * random place to check, but there is no better place.
>
> Since the assert is no longer in a random function body, it seems we can
> remove the second sentence.
Committed with the discussed adjustments.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Luzanov | 2022-12-15 09:42:00 | Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX |
| Previous Message | Pavel Luzanov | 2022-12-15 09:31:00 | Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX |