| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Move strtoint() to common |
| Date: | 2018-03-14 13:17:07 |
| Message-ID: | 4ca0838e-9cd3-bfae-b6b8-51ba0eabcabe@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 3/13/18 21:10, David Rowley wrote:
> On 14 March 2018 at 08:10, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>> Move strtoint() to common
>>
>> Buildfarm seems to think this isn't quite baked for Windows.
>
> Yeah, "restrict" seems to be C99, and the Microsoft compilers don't
> quite know about that yet. The attached compiles fine for me on a
> windows machine.
We have a configure test for it and we already use it elsewhere. Is it
not working?
I think the problem is rather that we somehow need to tell it to link
src/common/string.c into pgtypeslib.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-03-14 13:28:31 | pgsql: Fix comment for ExecProcessReturning |
| Previous Message | Peter Eisentraut | 2018-03-14 13:03:58 | pgsql: Add tests for reinit.c |