| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Foreign tables don't enforce the partition constraint |
| Date: | 2017-04-07 04:45:24 |
| Message-ID: | 4c7579cd-9d96-72ff-69a1-2e0e71e61a0d@lab.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/04/03 16:44, Amit Langote wrote:
> Hi Ashutosh,
>
> On 2017/04/03 15:49, Ashutosh Bapat wrote:
>>>> Similarly, a partition constraint
>>>> should also be enforced at the foreign server. Probably we should
>>>> update documentation of create foreign table to mention this.
>>>
>>> That is a good idea.
>>>
>>> Here's the patch.
>
> Thanks for creating the patch.
>
> + Constraints and partition bounds on foreign tables (such as
>
> We use "partition constraint" instead of "partition bounds" to mean the
> implicit constraint of a partition (there are a few instances of that in
> the documentation). So, perhaps this could be written as: Constraints
> (both the user-defined constraints such as <literal>CHECK</>
> or <literal>NOT NULL</> clauses and the partition constraint) are not
> enforced by the core <productname>PostgreSQL</> system, ...
>
> And once we've mentioned that a constraint means one of these things, we
> need not repeat "partition bounds/constraints" in the subsequent
> paragraphs. If you agree, attached is the updated patch.
Since it seems that we agree that this documentation tweak is good idea, I
will add this to the open items list to avoid it being missed.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2017-04-07 05:10:59 | Re: Interval for launching the table sync worker |
| Previous Message | Amit Langote | 2017-04-07 04:42:19 | Re: No-op case in ExecEvalConvertRowtype |