| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove MsgType type |
| Date: | 2025-12-27 22:47:30 |
| Message-ID: | 4c5d1641-6752-46bd-b582-e0b5e8cec176@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22.12.25 10:06, Chao Li wrote:
>> On Dec 22, 2025, at 16:46, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>
>> Presumably, the C type MsgType was meant to hold the protocol message type in the pre-version-3 era, but this was never fully developed even then, and the name is pretty confusing nowadays. It has only one vestigial use for cancel requests that we can get rid of. Since a cancel request is indicated by a special protocol version number, we can use the ProtocolVersion type, which MsgType was based on. (If this is also found confusing, we could also use uint32 directly.)
>> <0001-Remove-MsgType-type.patch>
>
> LGTM. I searched over the source tree, MsgType had only a single usage before the patch, so it makes sense to remove it.
committed, thanks
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikolay Samokhvalov | 2025-12-27 23:08:12 | Proposal: Add rows_filtered column to pg_stat_statements for index opportunity detection |
| Previous Message | Tom Lane | 2025-12-27 21:31:37 | Fixing some ancient errors in hash join costing |